[3.16] backport: #11009 #10962 #11051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiste
force-pushed
the
backport-11009
branch
from
50ad803
to
7b08e1c
Compare
maiste
force-pushed
the
backport-11009
branch
from
7b08e1c
to
3b0ae2e
Compare
…10962) * Call the C++ compiler with -std=c++11 when using OCaml >= 5.0 Signed-off-by: Etienne Marais <[email protected]>
strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. Signed-off-by: Kate <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
maiste
force-pushed
the
backport-11009
branch
from
3b0ae2e
to
12221e4
Compare
maiste
changed the title
Leonidas-from-XIV
changed the title
kit-ty-kate
reviewed
Oct 29, 2024
Co-authored-by: Kate <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
Leonidas-from-XIV
requested changes
Oct 29, 2024
maiste
commented
Oct 29, 2024
Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
Leonidas-from-XIV
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #11009 and #10962. They are backported together as one is the fix of the other one.